Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tight layout setting from draw_EGraph_matplotlib, remove docformatter from workflow #125

Merged
merged 6 commits into from
Apr 27, 2023

Conversation

ilan-tz
Copy link
Collaborator

@ilan-tz ilan-tz commented Apr 27, 2023

Context for changes

  • Tight layout setting from draw_EGraph_matplotlib as it was causing a warning.
  • Docformatter was causing issues.
  • Bug fixes:
    • Remove the tight layout setting from draw_EGraph_matplotlib.
    • Remove docformatter from workflow.

Example usage and tests

  • Not Applicable

Performance results justifying changes

  • Not Applicable

Workflow actions and tests

  • Not Applicable

Expected benefits and drawbacks

Expected benefits:

  • Warning no longer displayed.

Possible drawbacks:

  • It is possible that some EGraph plots will be awkwardly cut off.

Related Github issues

  • Not Applicable

Checklist and integration statements

  • My Python and C++ codes follow this project's coding and commenting styles as indicated by existing files. Precisely, the changes conform to given black, docformatter and pylint configurations.
  • I have performed a self-review of these changes, checked my code (including for codefactor compliance), and corrected misspellings to the best of my capacity. I have synced this branch with others as required.
  • I have added context for corresponding changes in documentation and README.md as needed.
  • I have added new workflow CI tests for corresponding changes, ensuring codecoverage is 95% or better, and these pass locally for me.
  • I have updated CHANGELOG.md following the template. I recognize that the developers may revisit CHANGELOG.md and the versioning, and create a Special Release including my changes.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #125 (9c0c089) into main (cf37d0e) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 9c0c089 differs from pull request most recent head 6ee7a0b. Consider uploading reports for the commit 6ee7a0b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   95.99%   95.87%   -0.13%     
==========================================
  Files          37       37              
  Lines        2423     2422       -1     
==========================================
- Hits         2326     2322       -4     
- Misses         97      100       +3     
Impacted Files Coverage Δ
flamingpy/utils/viz.py 90.53% <ø> (+0.46%) ⬆️
flamingpy/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf37d0e...6ee7a0b. Read the comment docs.

@ilan-tz ilan-tz changed the title Remove tight layout setting from draw_EGraph_matplotlib Remove tight layout setting from draw_EGraph_matplotlib, remove docformatter from workflow Apr 27, 2023
Copy link
Contributor

@sduquemesa sduquemesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! 🥐

@ilan-tz ilan-tz merged commit 043e4ce into main Apr 27, 2023
8 checks passed
@ilan-tz ilan-tz deleted the layout_fix branch April 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants