-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial pipeline, error correction blurb, and a couple of tutorials #24
Conversation
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 96.27% 96.32% +0.04%
==========================================
Files 35 35
Lines 2123 2123
==========================================
+ Hits 2044 2045 +1
+ Misses 79 78 -1
Continue to review full report at Codecov.
|
…AI/flamingpy into demo-gallery
This reverts commit 35b4bda.
* Update quantum_error_correction.rst Add the QEC blurb Co-Authored-By: Pavithran S Iyer <33754449+paviudes@users.noreply.github.com> * Update quantum_error_correction.rst Co-Authored-By: Pavithran S Iyer <33754449+paviudes@users.noreply.github.com> * Update graph state tutorial, test image inclusion * Update run_graph_states.py * Add error correction tutorial * Add images to graph state tutorial * fix thumb link * fix image hyperlink * add space to image instruction Co-authored-by: Theodor <theodor.isacsson@gmail.com> * add thumbnail to ec tutorial * remove `align` from math statements * Apply suggestions from code review Co-authored-by: Theodor <theodor.isacsson@gmail.com> * add label/cross-ref and minor fixes * fix ref * add ref to quantum-error-correction * Apply suggestions from code review @thisac Co-authored-by: Theodor <theodor.isacsson@gmail.com> * Update run_graph_states.py * improve tooltips text * center and resize images * Modify circuit diagrams slightly * Apply suggestions from code review * Update doc/tutorials/run_error_correction.py * Update run_graph_states.py * Update run_error_correction.py Co-authored-by: ilan-tz <57886357+ilan-tz@users.noreply.github.com> Co-authored-by: Pavithran S Iyer <33754449+paviudes@users.noreply.github.com> Co-authored-by: Theodor <theodor.isacsson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A simple and effective pipeline for adding tutorials. Thank you also to @paviudes for the QEC blurb!
Co-authored-by: Theodor <theodor.isacsson@gmail.com>
Co-authored-by: Theodor <theodor.isacsson@gmail.com>
Implement matching graph abstraction so that user can readily switch between backends.
Context for changes
Set the infrastructure to have a gallery containing demos in FlamingPy
Example usage and tests
To add a tutorial, use the
gallery-item
directive from thexanadu-sphinx-theme
. For the new document to be compiled its filename should start withrun_
. Thumbnails will be created out of the first figure generated and stored intutorials/_out/images/thumb/
with the same name of the tutorial prepended withsphx_glr_
.Example
A new tutorial named
run_intro_tutorial.py
is created inflamingpy/doc/tutorials/run_intro_tutorial.py
. To add the tutorial to the gallery useon the
flamingpy/doc/usage/tutorials.rst
file.Every new tutorial should be a python executable script with ReST formatting.
Performance results justifying changes
Workflow actions and tests
This should be tested and built by the Create Documentation / sphinx (pull_request) action.
Expected benefits and drawbacks
Expected benefits:
Possible drawbacks:
Related Github issues
Checklist and integration statements
black
,docformatter
andpylint
configurations.README.md
as needed.CHANGELOG.md
following the template. I recognize that the developers may revisitCHANGELOG.md
and the versioning, and create a Special Release including my changes.