Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate XIRProgram with Jet gate declarations #34

Merged
merged 4 commits into from Jun 24, 2021
Merged

Conversation

Mandrenkov
Copy link
Collaborator

Context:
Adding support for user gate definitions in the Jet-XIR interpreter is made significantly easier with a centralized data structure which holds the interface of each gate.

Description of the Change:

  • A new function, get_xir_program(), is introduced which returns an XIRProgram declaring the gates implemented by Jet.
  • An unregister method has been added to the GateFactory class to better encapsulate the GateFactory tests.

Benefits:

  • The capabilities of the Jet-XIR interpreter can be easily queried for validation purposes.

Possible Drawbacks:
None

Related GitHub Issues:
None

@Mandrenkov Mandrenkov added the enhancement ✨ New feature or request label Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jun 23, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
521 tests ±0  521 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit af40c7d. ± Comparison against base commit af40c7d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 23, 2021

Test Report (C++) on MacOS

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
521 tests ±0  521 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit af40c7d. ± Comparison against base commit af40c7d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@brownj85 brownj85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just a couple suggestions

python/jet/interpreter.py Outdated Show resolved Hide resolved
python/tests/jet/test_interpreter.py Outdated Show resolved Hide resolved
@Mandrenkov Mandrenkov merged commit af40c7d into main Jun 24, 2021
@Mandrenkov Mandrenkov deleted the jet-xir-program branch June 24, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants