New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python test report #39
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test Report (Python) on Ubuntu 1 files 1 suites 6s ⏱️ Results for commit d240052. ♻️ This comment has been updated with latest results. |
Test Report (C++) on Ubuntu 1 files 1 suites 0s ⏱️ Results for commit d240052. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me code-wise, I was just wondering if you could give a rationale for removing the C++ MacOS test report? If it's almost always identical to Ubuntu but not always, wouldn't it make it more difficult to understand problems that come up for MacOS? Is it a readability thing?
Sure. I did this for two reasons:
To clarify, I think the Ubuntu and MacOS test reports only differed when Jet failed to compile on one of the operating systems; I don't think there are any instances where both reports listed more than one test but were otherwise different. With respect to your question, I would argue this is not a concern since any test failures on MacOS would still be reported by the corresponding GitHub Actions check. The test report action simply posts a comment on a PR stating how many tests have been added relative to the base branch and which of these tests passed or failed in the latest CI run.
Yes, exactly. |
Context:
The Python component of Jet has grown extensively since the GitHub Actions workflows were added to the repository. This PR aims to put the Jet Python code on equal footing with the Jet C++ code in terms of CI visibility.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
None