Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CudaTensor CMake patch #56

Merged
merged 2 commits into from Jul 30, 2021
Merged

CudaTensor CMake patch #56

merged 2 commits into from Jul 30, 2021

Conversation

trevor-vincent
Copy link
Contributor

@trevor-vincent trevor-vincent commented Jul 29, 2021

Context:

Compiler errors when running cmake/make due to taskflow dependency in CudaTensor

Description of the Change:

Remove taskflow dependency in CudaTensor

Benefits:

No compiler errors after running cmake/make

Possible Drawbacks:

None

Related GitHub Issues:

@github-actions
Copy link

github-actions bot commented Jul 29, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
521 tests ±0  521 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3d2846b. ± Comparison against base commit 3d2846b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 29, 2021

Test Report (Python) on Ubuntu

    1 files  ±0      1 suites  ±0   8s ⏱️ ±0s
542 tests ±0  542 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3d2846b. ± Comparison against base commit 3d2846b.

♻️ This comment has been updated with latest results.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Once this is merged we can tag the repo as 0.2.1 (v0.2.1) and I'll issue a separate PR to update the CMake tags in the examples.

@mlxd mlxd merged commit 3d2846b into main Jul 30, 2021
@Mandrenkov Mandrenkov linked an issue Aug 3, 2021 that may be closed by this pull request
@Mandrenkov Mandrenkov deleted the cudatensor-cmake-patch branch October 18, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU code fails to compile for provided CMake examples
2 participants