Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip install from GitHub repository #66

Merged
merged 7 commits into from Aug 23, 2021
Merged

Pip install from GitHub repository #66

merged 7 commits into from Aug 23, 2021

Conversation

Mandrenkov
Copy link
Collaborator

Context:
The current Python installation instructions in the README do not work since Jet has not been published to PyPI yet.

Description of the Change:

  • The pip install command in the README has been updated to use the GitHub repository.
  • The version of the Jet C++ library has been incremented to 0.2.2 (and the Python version to 0.2.2-dev).

Benefits:

  • The README instructions are more accurate.

Possible Drawbacks:
None.

Related GitHub Issues:
None.

@Mandrenkov Mandrenkov added the documentation 📚 Improvements or additions to documentation label Aug 23, 2021
@github-actions
Copy link

github-actions bot commented Aug 23, 2021 •
edited

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
521 tests ±0  521 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
870 runs  ±0  870 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23f2e6b. ± Comparison against base commit 23f2e6b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 23, 2021 •
edited

Test Report (Python) on Ubuntu

    1 files  ±0      1 suites  ±0   10s ⏱️ ±0s
554 tests ±0  554 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 23f2e6b. ± Comparison against base commit 23f2e6b.

♻️ This comment has been updated with latest results.

@Mandrenkov Mandrenkov marked this pull request as draft August 23, 2021 13:25
@Mandrenkov Mandrenkov marked this pull request as ready for review August 23, 2021 13:39
josh146
josh146 approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mandrenkov!

docs/conf.py Outdated Show resolved Hide resolved
python/xir/program.py Show resolved Hide resolved
josh146
josh146 reviewed Aug 23, 2021
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@Mandrenkov Mandrenkov merged commit 23f2e6b into main Aug 23, 2021
@Mandrenkov Mandrenkov deleted the pip-install-from-github branch August 23, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh146 josh146 josh146 approved these changes

Assignees
No one assigned
Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mandrenkov @josh146