Adds Torontonian sampling support to the Gaussian backend #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=========================================
Coverage ? 97.59%
=========================================
Files ? 36
Lines ? 5325
Branches ? 0
=========================================
Hits ? 5197
Misses ? 128
Partials ? 0
Continue to review full report at Codecov.
|
trbromley
reviewed
Jul 30, 2019
| """Tests that make use of the Fock basis representation.""" | ||
|
|
||
| def measure_threshold_gaussian_warning(self, setup_backend): | ||
| """Tests that Threshold measurements are not implemented when shots != 1. |
There was a problem hiding this comment.
Is this the right docstring?
Co-Authored-By: Tom Bromley <49409390+trbromley@users.noreply.github.com>
… in the gaussian backend
josh146
requested changes
Jul 31, 2019
|
@josh146 any idea what this |
Co-Authored-By: Josh Izaac <josh146@gmail.com>
josh146
approved these changes
Jul 31, 2019
trbromley
reviewed
Jul 31, 2019
trbromley
approved these changes
Jul 31, 2019
co9olguy
requested changes
Aug 8, 2019
Co-Authored-By: Nathan Killoran <co9olguy@users.noreply.github.com>
josh146
changed the title
…er zero or one in all the modes
|
All looks good from my end now @nquesada |
|
As one last commit before merging, can you update the changelog, adding a one-to-two sentence description of the PR to the relevant section, and also link back to the PR. |
josh146
reviewed
Aug 13, 2019
co9olguy
reviewed
Aug 19, 2019
Co-Authored-By: Josh Izaac <josh146@gmail.com>
co9olguy
approved these changes
Aug 19, 2019
josh146
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change:
Adds threshold (torontonian) sampling to the capabilities of the Gaussian backend.
Benefits:
Threshold samples can be generated directly instead of doing PNR and then threshold by hand. Should give significant saving in time and it is useful for apps upstream.
Possible Drawbacks:
Related GitHub Issues: