Adding fock gkps #553
Merged
Adding fock gkps #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 76 76
Lines 8397 8429 +32
=======================================
+ Hits 8249 8281 +32
Misses 148 148
Continue to review full report at Codecov.
|
nquesada
commented
Mar 9, 2021
| @@ -383,7 +383,7 @@ def prepare_gaussian_state(self, r, V, modes): | |||
| self.circuit.from_covmat(cov, modes) | |||
| self.circuit.from_mean(means, modes) | |||
|
|
|||
| def prepare_cat(self, alpha, phi, representation, cutoff, D): | |||
| def prepare_cat(self, alpha, phi, representation, amplcutoff, D): | |||
There was a problem hiding this comment.
Note that in the original PR for the bosonic backend we use cutoff for the small real number used to decide whether to include a Gaussian in phase space. This is inconsistent with the use of cutoff for the Fock space truncation thus I've renamed it in the bosonic backend.
nquesada
commented
Mar 9, 2021
elib20
reviewed
Mar 11, 2021
elib20
reviewed
Mar 11, 2021
nquesada
requested review from
elib20 and
thisac
and removed request for
thisac and
antalszava
Co-authored-by: elib20 <53090166+elib20@users.noreply.github.com>
elib20
reviewed
Mar 11, 2021
Co-authored-by: elib20 <53090166+elib20@users.noreply.github.com>
elib20
reviewed
Mar 11, 2021
antalszava
approved these changes
Mar 11, 2021
|
|
||
|
|
||
| @functools.lru_cache() | ||
| def squaregkpState(theta, phi, epsilon, ampl_cutoff, cutoff): |
There was a problem hiding this comment.
Suggested change
| def squaregkpState(theta, phi, epsilon, ampl_cutoff, cutoff): | |
| def square_gkp_state(theta, phi, epsilon, ampl_cutoff, cutoff): |
Co-authored-by: antalszava <antalszava@gmail.com>
Co-authored-by: antalszava <antalszava@gmail.com>
nquesada
commented
Mar 12, 2021
nquesada
commented
Mar 12, 2021
elib20
approved these changes
Mar 12, 2021
nquesada
commented
Mar 12, 2021
nquesada
commented
Mar 12, 2021
Co-authored-by: elib20 <53090166+elib20@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preparation methods for the GKP states in the Fock backend