Add documentation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Closed
Mandrenkov
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Excellent work, @josh146! 🎉
We probably should have had this ready for the v0.1.0 release but better late than never!
| @@ -25,7 +26,7 @@ def setup(app): | |||
| "details": DetailsDirective, | |||
| "gallery-item": GalleryItemDirective, | |||
| "index-card": IndexCardDirective, | |||
| "related-demo": RelatedDemoDirective, | |||
| "related": RelatedDemoDirective, | |||
There was a problem hiding this comment.
Doesn't related-demo match the naming of the other directives better? 🤔
There was a problem hiding this comment.
This was me sneaking in a feature 😬 I realized that the sidebar section just says "Related", and I realized this could be useful beyond just demos
There was a problem hiding this comment.
Should we rename the directive then too, @josh146?
Suggested change
| "related": RelatedDemoDirective, | |
| "related": RelatedDirective, |
There was a problem hiding this comment.
Oops, I should have done that at the time
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Mandrenkov
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.