Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heading and navbar font to Quicksand #15

Merged
merged 34 commits into from
Sep 10, 2022
Merged

Update heading and navbar font to Quicksand #15

merged 34 commits into from
Sep 10, 2022

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Sep 5, 2022

No description provided.

Mandrenkov
Mandrenkov approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn't know we only used Noto Sans for the header and footer. 🤔

As a side note, should we increase the font size for the navbar title?

Screen Shot 2022-09-06 at 2 38 03 PM

doc/conf.py Outdated
@@ -109,7 +109,7 @@
# Xanadu theme options (see theme.conf for more information).
html_theme_options = {
"navbar_name": "Xanadu Sphinx Theme",
"navbar_logo_colour": "#2d7c7f",
"navbar_logo_colour": "#f48fb1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎣

xanadu_sphinx_theme/static/xanadu.css_t
font-weight: 400;
font-family: 'Roboto', sans-serif !important;
font-weight: 500;
font-family: 'Quicksand', sans-serif !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Quicksand in quotation marks here and below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I just copied what Google Fonts told me to do in their code snippets :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough although it would be nice to be consistent across the file! 🔗

@josh146
Copy link
Member Author

josh146 commented Sep 6, 2022

As a side note, should we increase the font size for the navbar title?

At the moment it is 16px, I think I prefer it as it is in terms of how it is balanced across the rest of the page 🤔

I had a quick look at other OSS packages:

  • Torch: 20px
  • TF: 14px
  • NumPy: 16px

I think Torch only gets away with such large font for their navbar because their navbar is super thick

@Mandrenkov
Copy link
Collaborator

At the moment it is 16px, I think I prefer it as it is in terms of how it is balanced across the rest of the page 🤔

I had a quick look at other OSS packages:

  • Torch: 20px
  • TF: 14px
  • NumPy: 16px

I think Torch only gets away with such large font for their navbar because their navbar is super thick

Ah, good call on the OSS comparison. I agree this should be fine! 👌

Base automatically changed from no-sidebar to master September 10, 2022 01:03
@josh146 josh146 merged commit 61458b9 into master Sep 10, 2022
@josh146 josh146 deleted the change-font branch September 10, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mandrenkov Mandrenkov Mandrenkov approved these changes

@AndrewGardhouse AndrewGardhouse AndrewGardhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josh146 @Mandrenkov @AndrewGardhouse