Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support navbar images #21

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Support navbar images #21

merged 9 commits into from
Sep 27, 2022

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Sep 27, 2022

Context: Adds support for images in the navigation bar.

Description of the Change: For the navbar_left_links configuration option, the "img" key can be used to specify an image for the navbar link, alongside "img_width" to specify the width of the image.

Benefits: As above.

Possible Drawbacks: n/a

Related GitHub Issues: n/a

@josh146 josh146 changed the title Support navbar image Support navbar images Sep 27, 2022
.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🖼️

.github/CHANGELOG.md Outdated Show resolved Hide resolved
doc/conf.py Outdated Show resolved Hide resolved
xanadu_sphinx_theme/header.html Outdated Show resolved Hide resolved
doc/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
Base automatically changed from fix-navbar-shadow to master September 27, 2022 13:37
@josh146 josh146 merged commit 0a2f55f into master Sep 27, 2022
@josh146 josh146 deleted the support-navbar-image branch September 27, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants