Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animations to navbar dropdowns on mobile #45

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

Mandrenkov
Copy link
Collaborator

@Mandrenkov Mandrenkov commented Oct 12, 2023

Context:

The PennyLane website has transition animations when a navbar dropdown is expanded or collapsed on mobile.

Description of the Change:

  • Added an animation when the mobile navbar dropdown is expanded or collapsed.
  • Added an animation when a dropdown from a navbar link on mobile is expanded or collapsed.

Benefits:

  • There is greater parity between the consumers of the XST and the main PennyLane website.

Possible Drawbacks:

None.

Related GitHub Issues:

None.


Preview: https://xanadu-sphinx-theme--45.org.readthedocs.build/en/45/

@Mandrenkov Mandrenkov marked this pull request as draft October 13, 2023 13:25
@Mandrenkov Mandrenkov marked this pull request as ready for review October 13, 2023 13:41
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@LucasSilbernagel
Copy link
Contributor

Nice! Could we get a preview link?

@Mandrenkov
Copy link
Collaborator Author

Nice! Could we get a preview link?

Oops! I've added it now. Sorry about that, @LucasSilbernagel !

Copy link
Contributor

@LucasSilbernagel LucasSilbernagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Mandrenkov !

@Mandrenkov Mandrenkov merged commit 9803959 into master Oct 13, 2023
2 checks passed
@Mandrenkov Mandrenkov deleted the sc-46520-mobile-dropdown-animations branch October 13, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants