-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated version bumps with GitHub Actions workflows #12
Conversation
@Mandrenkov, I haven't given it a full review yet but just skimming now it looks great ! Just wondering why you choose to remove the dependance on a python script? I like that everything is self contained in the workflow, I just worry that if in the future one wishes to add additional functionality, it will be limiting? It also seems that the functionality of cleaning and reformatting the changelog as well as adding the other headers has been removed. Is it okay to leave those out for XIR? |
Looks good to me after a skim through 👍 It's nice to have the commands within the workflow files. 🙂 One thing while going through is that a different type of skillset is required by the readers to understand the steps here (instead of Python, readers need to be familiar more so with the exact options of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great to have! Thanks @Mandrenkov! 💯
A few comments, but nothing major. Has this been tested to work properly, or will the next release be the first proper test?
Thanks for the comment, @Jaybsoni!
Actually, it is for exactly that first reason: to make everything self-contained in the workflow! Using Python is definitely a viable option but there are usually other tools which can do this type of processing in a more concise way.
Yes, that's right. This is mostly because multi-line text processing is not very easy to do in Bash (although still possible). I would argue that the former functionality is not necessary since these sorts of mistakes should be caught in the PRs that contribute those changes. I will concede that the latter is slightly more useful, although perhaps not a deal-breaker. |
Thanks for the review, @antalszava!
Yes, that is a very good point. But utilities like
There are two main reasons why I decided to go with command-line programs:
This approach also requires no additional dependencies and is a good opportunity to learn about tools like |
Thanks for the review, @thisac!
Yes, I've tested this locally using https://github.com/nektos/act! It works as expected but the only way to know if they work for sure is to actually run the workflows using a real GitHub Actions runner! This is a pretty low-risk move though since the workflows just create PRs rather than commit code or tags directly to the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few minor clarifications 👍🏼
Thanks, @Jaybsoni! |
* Add version bump workflows based on XanaduAI/xir#12 * Add @Mandrenkov to list of v0.2.0 contributors
Context:
To release a new version of the XIR, two PRs are required:
-dev
suffix from the current version.-dev
suffix.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
None.