Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically upload XIR package to PyPI upon release #9

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Automatically upload XIR package to PyPI upon release #9

merged 6 commits into from
Dec 10, 2021

Conversation

Mandrenkov
Copy link
Collaborator

Context:
Currently, new releases of the XIR must be manually uploaded to PyPI.

Description of the Change:

  • Added a GitHub Actions workflow for automatically uploading the main branch of the XIR to PyPI when a new release is created on GitHub. Before uploading the package to PyPI, however, the workflow ensures that all the tests pass.

Benefits:

  • GitHub releases are synchronized with PyPI releases (assuming there are no issues with the tests).

Possible Drawbacks:

  • Anyone with write access to the XIR repository can upload a new version of the XIR to PyPI.

Related GitHub Issues:
None.

trbromley
trbromley approved these changes Dec 10, 2021
View reviewed changes
Copy link
Collaborator

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mandrenkov!

.github/CHANGELOG.md Outdated Show resolved Hide resolved
thisac
thisac approved these changes Dec 10, 2021
View reviewed changes
xir/_version.py Show resolved Hide resolved
Mandrenkov and others added 2 commits December 10, 2021 17:42
@Mandrenkov @trbromley
Clarify release location in changelog
aa3580d 
Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com>
@Mandrenkov
Remove extra whitespace and convert hash into list
b0b0a7a
@Mandrenkov Mandrenkov merged commit a7c1129 into main Dec 10, 2021
@Mandrenkov Mandrenkov deleted the sc-11760-pypi-upload-workflow branch December 10, 2021 22:51
@Mandrenkov Mandrenkov mentioned this pull request Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisac thisac thisac approved these changes

@trbromley trbromley trbromley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mandrenkov @thisac @trbromley