Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Blur with a "Source" Mask performs double addref #818

Closed
Xaymar opened this issue Jun 8, 2022 · 1 comment · Fixed by #987
Closed

Blur with a "Source" Mask performs double addref #818

Xaymar opened this issue Jun 8, 2022 · 1 comment · Fixed by #987
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.

Comments

@Xaymar
Copy link
Owner

Xaymar commented Jun 8, 2022

Operating System

(Other)

OBS Studio Version?

27.1

StreamFX Version

0.12.0a1

OBS Studio Log

N/A

OBS Studio Crash Log

No response

Current Behavior

libOBS crashes on exit due to a double free.

Expected Behavior

libOBS should not crash on exit.

Steps to Reproduce the Bug

  1. Create two Scenes, named A and B.
  2. In "B", add any Source.
  3. In "A", add any Source, named "A-1".
  4. To "A-1" add a Blur filter, and set it to use "B" as the Mask.
  5. Close all dialogs.
  6. Close OBS Studio.
  7. Crash due to double destroy.

Any additional Information we need to know?

No response

@Xaymar Xaymar added bug Bugs such as crashing, freezing, broken functionality, etc. status:help-wanted labels Jun 8, 2022
@Xaymar Xaymar added this to the 0.12 milestone Jun 8, 2022
@Xaymar Xaymar removed this from the 0.12 milestone Jul 31, 2022
@Xaymar Xaymar added this to the 0.12 milestone Sep 5, 2022
@Xaymar
Copy link
Owner Author

Xaymar commented Dec 2, 2022

Confirmed still happening on current master at the time of writing. Having a Blur with a source mask results in that mask leaking in the next scene collection silently.

@Xaymar Xaymar linked a pull request Dec 2, 2022 that will close this issue
10 tasks
@Xaymar Xaymar added this to the v0.12 milestone May 25, 2023
@Xaymar Xaymar added this to the Blur (Component, Filter) milestone Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs such as crashing, freezing, broken functionality, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant