Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#818 Don't self-reference when masking is enabled #987

Merged
merged 2 commits into from
Dec 2, 2022
Merged

#818 Don't self-reference when masking is enabled #987

merged 2 commits into from
Dec 2, 2022

Conversation

Xaymar
Copy link
Contributor

@Xaymar Xaymar commented Dec 2, 2022

Explain the Pull Request

Fixes a double-addref performed by anything that uses source_texture, a legacy class for rendering sources to texture.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@Xaymar Xaymar linked an issue Dec 2, 2022 that may be closed by this pull request
Blur with a "Source" Mask performs double addref #818
Closed
@Xaymar Xaymar merged commit e404239 into root Dec 2, 2022
@Xaymar Xaymar deleted the bug/818-blur-with-a-source-mask-performs-double-addref branch December 2, 2022 04:01
@Xaymar Xaymar added this to the 0.12 milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blur with a "Source" Mask performs double addref
1 participant
@Xaymar