This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Don't show path selection for System & User mode #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
patch/windows-bundle
branch
from
b9e1c74
to
568a86b
Compare
…User mode The location for System-wide and User-only installation depend on Windows-managed locations, which means that they will never require a user to select the correct location. Therefore it is best to hide the page in all modes except for Portable, which should still offer a path to extract to.
Xaymar
force-pushed
the
patch/windows-bundle
branch
from
568a86b
to
7053dbe
Compare
|
Seems like this can still be adjusted with /DIR=, so functionality as expected. Normal users will never end up with CLI usage anyway |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
The directory selection for System & User mode only serves to confuse end users, as the default is already correct in every possible case. We rely on Windows-managed paths, which are nearly impossible to change after Windows has been installed, so this directory choice should only be offered for Portable users.
Additionally, we should use the built in RegWriteExpandStringValue instead of a custom call.
Completion Checklist
CODEOWNERS.