You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.
However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.
I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.
pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.
However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.
I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.
rules_docker not needed. do a git diff to understand why
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
pip_install
to referencemy_deps
rather thanpip3_import
and thenload
Closes #108
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)