Skip to content
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.

Use pip_install to fetch my_deps #109

Closed
wants to merge 7 commits into from
Closed

Use pip_install to fetch my_deps #109

wants to merge 7 commits into from

Conversation

milan-tom
Copy link
Collaborator

@milan-tom milan-tom commented Mar 23, 2021

Uses pip_install to reference my_deps rather than pip3_import and then load

Closes #108


This change is Reviewable

@milan-tom
Copy link
Collaborator Author

After solving #108 with this solution, I seem to run into #79 again.

@milan-tom milan-tom added the bug Something isn't working label Mar 23, 2021
@milan-tom milan-tom self-assigned this Mar 27, 2021
@milan-tom milan-tom closed this Mar 27, 2021
@milan-tom
Copy link
Collaborator Author

Solution is to increase the TIMEOUT not this: #109

#108 (comment)

@milan-tom milan-tom reopened this Mar 27, 2021
@milan-tom milan-tom closed this Mar 27, 2021
@milan-tom milan-tom deleted the fix-my-deps-timeout branch March 28, 2021 17:35
@milan-tom milan-tom restored the fix-my-deps-timeout branch March 28, 2021 17:36
@milan-tom milan-tom reopened this Mar 29, 2021
@milan-tom
Copy link
Collaborator Author

pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.

However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.

I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.

@gitpod-io
Copy link

gitpod-io bot commented May 1, 2021

@milan-tom milan-tom mentioned this pull request May 2, 2021
@codecakes
Copy link
Contributor

pip3_import is now the legacy way to import pip dependencies using rules_python. The new way is using pip_install providing backwards compatibility with rules_python_external.

However, upon inspection of the deprecation message for rules_python_external, one is alerted that the repository has been merged into bazelbuild/rules_python@v0.1.0. Clicking this link will lead to the releases page for release 0.1.0. From here, selecting the code option will lead to the source code for the 0.1.0 release. Confusingly, the Readme in this source code bears the documentation for v0.0.2. Hence, I believe that the confusion about pip3_import being the latest method arose due to this discrepancy.

I have also used this pull request to update rules_docker to v0.16.0, because v0.14.4 is frankly incompatible with rules_python v0.1.0.

rules_docker not needed. do a git diff to understand why

@milan-tom
Copy link
Collaborator Author

Closed by #122

@milan-tom milan-tom closed this May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout when fetching @my_deps
2 participants