Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend/features/home page [DO NOT MERGE!] #89

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

codecakes
Copy link
Collaborator

@codecakes codecakes commented Aug 24, 2020

@ksr89 broken down scss. use react css for non-home pages only. use only home scss for home page;

image


This change is Reviewable

@codecakes codecakes added help wanted Extra attention is needed needs-review PRs to review labels Aug 24, 2020
@codecakes codecakes requested review from ksr89 and a team August 24, 2020 07:27
@codecakes codecakes marked this pull request as ready for review August 24, 2020 07:27
@codecakes codecakes changed the title Frontend/features/home page Frontend/features/home page [DO NOT MERGE!] Aug 24, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2020

This pull request introduces 1 alert when merging 724d6bb into 306ee8f - view on LGTM.com

new alerts:

  • 1 for Ambiguous HTML id attribute

@import "login.scss";
@import "error.scss";
@import "footer.scss";
@import "loader";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

@@ -0,0 +1 @@
@import "main";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

<div className="container">
<a className="navbar-brand" href="home.html">
<img width="150" src="website/static/images/logo.png" />
</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclosed regular expression.
Unrecoverable syntax error. (6% scanned).

@@ -4,6 +4,9 @@ import {
Route
} from "react-router-dom";

import '../stylesheets/main.scss';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -10,6 +10,7 @@ import Layout from './Layout';
import Login from './Login';
import Register from './Register';
import ForgotPassword from './ForgotPassword';
import Home from '../pages/Home';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2020

This pull request introduces 1 alert when merging 6bf8790 into 306ee8f - view on LGTM.com

new alerts:

  • 1 for Ambiguous HTML id attribute

@codecakes
Copy link
Collaborator Author

@martavasconcelos if you can generally take over this, would be a great starter ticket

@codecakes codecakes marked this pull request as draft August 27, 2020 21:04
@codecakes codecakes added first-timers-only @first_tmrs_only picks this up up-for-grabs labels Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only @first_tmrs_only picks this up good first issue Good for newcomers help wanted Extra attention is needed needs-review PRs to review up-for-grabs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants