Draft: /clock command #7

rsek · 2022-01-05T08:56:15Z

functional but extremely basic implementation of clocks, as described on p. 230 of Starforged (122421).

currently there's one kind of clock that can be set to one of the standard sizes (4, 6, 8, 10). it's an embed with a single button component that advances the clock by one segment. the Clock class has a constructor overload allowing it to parse a MessageEmbed back to a Clock for manipulation.

things i plan to add:

clock image resources for the 32 possible clock states (4 + 6 + 8 + 10 wedges, plus one empty state for each size)
campaign clock (p. 231): gets assigned an Ask the Oracle chance.
- "Advance" button rolls Ask the Oracle. if it's a "yes", it fills a segment. if it's also a match, it fills two segments. otherwise, no segment is filled.
- user gets adequate feedback so it's clear the AtA roll is happening (and not just a nonfunctional button)
- dropdown menu component allows changing AtA chance this after embed is generated. alternatively, 1 advance button for each AtA chance.

deferring for later PRs:

~~clocks as embed fields: a compact representation of a clock in a single embed field (+ constructor overload to parse it)~~
- ~~combined with a progress track embed to create scene challenge embed (probably with its own slash command)~~
- ~~attachable to any progress track~~
~~campaign clock "dashboard" embed to manage several clocks at once - allow them to be rolled in one go for session start~~

things i'm still considering:

on one hand, the book is pretty specific: "Never erase segments—clocks are inexorable and only move forward. If a clock is no longer a factor due to your actions or because of external events, the clock stops and is removed from play." on the other hand, reversibility is important. could live behind a "..."-type button?

inessential but could be fun:

have the embed colour gradate through blue => purple => red as clock fills :D

rsek · 2022-01-05T10:53:21Z

since some clocks leverage Ask the Oracle results (and would ideally report them like any other AtA so that it's clear to users what's happening), i'm also writing a class called OracleAnswer to make AtA more broadly applicable. since they're ultimately just a d% roll, they extend the Die class with several methods and properties, including ToEmbed(), IsYes, and IsMatch.

rsek · 2022-01-07T09:40:40Z

user-facing aspects of tension clocks and campaign clocks are pretty much done now - please test 'em if you get chance! main thing i could add is an embed so there's user feedback for clock fill events that aren't mediated by Ask the Oracle.

there's definitely some code cleanup i still need to do, though, including some silly workarounds because reflection was giving me grief. but once that's done i think this feature will be fit for human consumption.

since scene challenges have more moving parts (and since they involve progress tracks, which i might want to tweak anyways), i'll defer them for a future PR. they can be simulated with a tension clock + a formidable track in the mean time.

commit 0290367 Author: rsek <hello@rsek.ca> Date: Thu Jan 6 14:39:56 2022 -0800 proper files instead of symlinks, oops commit da988d2 Merge: b4982d8 27082a2 Author: rsek <hello@rsek.ca> Date: Wed Jan 5 16:25:48 2022 -0800 Merge branch 'XenotropicDev:main' into oracle-paths commit b4982d8 Author: rsek <hello@rsek.ca> Date: Tue Jan 4 18:17:11 2022 -0800 convert Source.Date string to DateOnly commit 1491258 Author: rsek <hello@rsek.ca> Date: Tue Jan 4 18:16:51 2022 -0800 renamed classes commit 4dad250 Author: rsek <hello@rsek.ca> Date: Tue Jan 4 13:55:26 2022 -0800 update gitignore commit 5082808 Author: rsek <hello@rsek.ca> Date: Tue Jan 4 13:53:21 2022 -0800 reorganizing dir, simplifying namespace declare commit 9bcc389 Merge: 502558d 9a6104c Author: rsek <hello@rsek.ca> Date: Tue Jan 4 14:30:37 2022 -0800 Merge branch 'XenotropicDev:main' into oracle-paths commit 502558d Merge: 017fdca 8e63be0 Author: rsek <hello@rsek.ca> Date: Mon Jan 3 21:00:13 2022 -0800 Merge branch 'XenotropicDev:main' into oracle-paths commit 017fdca Author: rsek <hello@rsek.ca> Date: Mon Jan 3 20:59:16 2022 -0800 comments to remove later commit 1c4e655 Author: rsek <hello@rsek.ca> Date: Mon Jan 3 20:54:29 2022 -0800 deserialize structured oracles commit b8a3c82 Author: rsek <hello@rsek.ca> Date: Mon Jan 3 20:35:40 2022 -0800 oracle data w/ structured categories in new format commit f19055b Author: rsek <hello@rsek.ca> Date: Mon Jan 3 18:48:25 2022 -0800 experimental autocomplete json commit fb6fbf9 Merge: 43b5cc9 6b2c0d0 Author: rsek <hello@rsek.ca> Date: Mon Jan 3 13:59:02 2022 -0800 Merge branch 'XenotropicDev:main' into oracle-paths commit 43b5cc9 Author: rsek <hello@rsek.ca> Date: Mon Jan 3 02:47:47 2022 -0800 initial commit

XenotropicDev

Overall this is good to go. There's a few things I wouldn't mind fixing before I merge it in though.

TheOracle2/AskTheOracle/OracleAnswer.cs

XenotropicDev · 2022-01-18T01:16:11Z

TheOracle2/AskTheOracle/OracleAnswer.cs

+      return str;
+    }
+  }
+  public static Dictionary<int, string> OddsString => new()


Is this a dictionary<int, string> solely to allow for spaces in the name? Because overall for both code, and possible future localization I think enum with a [DisplayAttribute] is a better way to go, even if it's annoying to get the string value out of the DissplayAttribute

XenotropicDev · 2022-01-18T01:21:08Z

TheOracle2/AskTheOracle/AskOption.cs

+  SmallChance = 10
+}
+
+public class AskDefs


This isn't being used as far as I can tell, and I don't really understand the intent of this code. I'm assuming this is something that got left over from some testing or something. I plan on removing it before I merge it in, but let me know if this is for something.

XenotropicDev · 2022-01-18T01:25:16Z

TheOracle2/AskTheOracle/OracleAnswer.cs

+  }
+  public Color OutcomeColor()
+  {
+    return IsYes switch


Style only: Overall I'm not a fan of doing this for something that could be handled very cleanly by a ternary operator. If the rest of the code in this class was using switches I'd be way more okay with it. If I'm in this file later on I reserve the right to change it to a ternary, but I'm really not too worried about it.

XenotropicDev · 2022-01-18T01:36:56Z

TheOracle2/AskTheOracle/OracleAnswer.cs

+  public EmbedBuilder ToEmbed()
+  {
+    string authorString = $"Ask the Oracle: {OddsString[Odds]}";
+    string footerString = IsMatch ? MatchMessage : "";


This seems like the MatchMessage should handle the IsMatch value, and either return null or String.Empty. That way the code is at the point of responsibility.

XenotropicDev · 2022-01-18T02:58:11Z

TheOracle2/DiscordHelpers/ComponentExtenstions.cs

+    SelectMenuComponent menu = component as SelectMenuComponent;
+    var values = interaction.Data.Values as string[];
+    var results = menu.Options.Where(option => values.Contains<string>(option.Value));
+    return results as SelectMenuOption[];


I think .ToArray() is better here, and it's a little more clear, but not really something to worry about.

XenotropicDev · 2022-01-18T02:59:58Z

TheOracle2/DiscordHelpers/ComponentExtenstions.cs

+    return option.Description;
+  }
+  /// <summary>
+  /// Gets the emojis of the originating menu options.


Am I missing the emoji part of this?

TheOracle2/GameObjects/Die.cs

XenotropicDev · 2022-01-18T03:09:58Z

TheOracle2/GameObjects/Move.cs

@@ -0,0 +1,59 @@
+namespace TheOracle2.GameObjects;


again, probably needs to be removed. I'm not sure if this is a rabbit hole we want to start down, but I don't think it is.

again, probably needs to be removed. I'm not sure if this is a rabbit hole we want to start down, but I don't think it is.

gah, i thought i deleted this! reason #534513 not to do such huge PRs, rsek. i made it when i was avoiding working with the database. then i realized that working with the db wasn't nearly so difficult as i assumed.

XenotropicDev · 2022-01-18T03:20:42Z

TheOracle2/ProgressTrack/Interfaces/ILogWidget.cs

@@ -0,0 +1,34 @@
+namespace TheOracle2.GameObjects;


I like where this is going, but I think it should probably use the event pattern, and remove most of the AlterOn stuff. I have some stuff planned for this space, so lets leave this for now, and revisit it in the upcoming player logs PR.

I like where this is going, but I think it should probably use the event pattern, and remove most of the AlterOn stuff. I have some stuff planned for this space, so lets leave this for now, and revisit it in the upcoming player logs PR.

sounds good - it's pretty skeletal and i don't think its method is presently use, but i wanted to reserve some space for it on certain interfaces/classes

rsek added 2 commits January 3, 2022 14:10

Merge branch 'main' of https://github.com/rsek/TheOracle2

0f08f1f

Merge branch 'XenotropicDev:main' into main

44be5dd

rsek mentioned this pull request Jan 5, 2022

implement clocks #9

Closed

XenotropicDev and others added 18 commits January 5, 2022 16:33

Feature: search command for Oracles, Moves, and Assets

2862b69

ignore local config that isn't in bin, idk why

f3d83d9

refactor: standard formatting

12081c7

fix: formatting

27a4701

rename: MomentumBurnOutcome, IsActionDieCanceled

4c79d7a

documenting IronswornRoll + some props

9e1bdc8

summary annotations

034fb35

AuthorText => RollTypeLabel

5ff153f

fix: removes double interaction response

cbf58b5

initial commit: clocks!

89f1d23

basic /clock implementation

b49b821

additional annotation/errors

930d254

separate Ask the Oracle enum for use by other cmds

e649660

first pass at OracleAnswer class

cce1662

rm default value for segments

994f821

add ToEmbedField method

f478071

dummy TensionClock for later

b90c644

CampaignClock button methods

909a6c8

rsek force-pushed the clocks branch from 35a2595 to 909a6c8 Compare January 6, 2022 00:34

clock imgs, tweaks to AtO output

1e20d18

rsek added 5 commits January 7, 2022 02:55

fixed missing images

7c3432a

reorganizing directories

7226fec

clock subcommands

6d16d05

fixing interactions + component names

c629909

Merge branch 'main' into clocks

013984a

rsek and others added 3 commits January 17, 2022 15:58

Merge branch 'XenotropicDev:main' into clocks

bee87b7

meta: code format cleanup

c6179ec

XenotropicDev requested changes Jan 18, 2022

View reviewed changes

XenotropicDev added 2 commits January 17, 2022 19:31

fix: breaking change for existing burn-roll buttons.

955f2bf

cleanup: remove commented file

5e084f0

XenotropicDev self-requested a review January 18, 2022 03:43

XenotropicDev and others added 20 commits January 17, 2022 19:54

cleanup: remove enum move file

10f4014

refactor: move isMatch check into MatchMessage

841c2d2

meta: Don't register the oracle dump command

3713ab0

refactor: renamed methods, and added some null handling

bbdace5

refactor: moved extension method

8eabbe9

refactor: use modulus for match detection

978f3da

fix compiler gripe about missing extensions

905171b

additional extensions for working with customids

42aaae8

cleanup extraneous file

47f3028

simplified to AskOption-only version

ef7b265

simplified to single command with presets

a245e4e

removing unneeded params from clock menu custom id

2f727cc

methods for parsing whether alerts should be sent

25f08df

add alert toggle button

92e3fc5

menu methods forward to button methods

9cea351

simplify counter customIds

c7cc608

fixed missing param

af349b5

substitute nicer strings til enum param available

e9d22ef

prevent empty tring from being parsed

9a3e5bc

cleanup

195e22e

XenotropicDev merged commit 6c3af2a into XenotropicDev:main Jan 18, 2022

rsek mentioned this pull request Jan 19, 2022

IWidget interface to standardize game elements with associated embeds #19

Closed

rsek mentioned this pull request Jan 27, 2022

bug: Ask the Oracle odds are inverted #37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: /clock command #7

Draft: /clock command #7

rsek commented Jan 5, 2022 •

edited

Loading

rsek commented Jan 5, 2022

rsek commented Jan 7, 2022

XenotropicDev left a comment

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

XenotropicDev Jan 18, 2022

rsek Jan 18, 2022

XenotropicDev Jan 18, 2022

rsek Jan 18, 2022

Draft: /clock command #7

Draft: /clock command #7

Conversation

rsek commented Jan 5, 2022 • edited Loading

rsek commented Jan 5, 2022

rsek commented Jan 7, 2022

XenotropicDev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rsek commented Jan 5, 2022 •

edited

Loading