This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(bug): resolve static initialization order problem of s_storage_rpc_req_codes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Nov 18, 2019
neverchanje
approved these changes
Nov 19, 2019
neverchanje
changed the title
neverchanje
pushed a commit
that referenced
this pull request
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function test of pegasus, insert into s_storage_rpc_req_codes will cause coredump, which was call by macro DEFINE_STORAGE_WRITE_RPC_CODE. But it`s normal when I runs onebox on local environment. It is caused by static initialization order probleom. Because DEFINE_STORAGE_WRITE_RPC_CODE was called first, but s_storage_rpc_req_codes was not initlized, so it produces coredump. As description, we have a 50%-50% chance of corrupting the program.