This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(utils): make logger decoupled from dsn runtime #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsn_runtime depends on config-lib, you misunderstood that config-lib depends on dsn_runtime. Every application can use if (!dsn_config_load(config_file, config_arguments)) {
printf("Fail to load config file %s\n", config_file);
return false;
} So logger depends on config-lib is reasonable. |
neverchanje
previously approved these changes
Feb 28, 2020
neverchanje
previously approved these changes
Feb 28, 2020
acelyc111
reviewed
Feb 28, 2020
acelyc111
previously approved these changes
Mar 2, 2020
neverchanje
approved these changes
Mar 2, 2020
acelyc111
approved these changes
Mar 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger API, is tightly coupled in rdsn runtime for historical issues. As a part of the long-term plan of rdsn (see #141 ) we decoupled it to make further refactoring possible.