-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy from and to stream #100
Conversation
Here the same as #94 probably applies, that we will want to add some extra functions to avoid the need to use dummybuffers. |
Wouldn't it make sense to do the API change in a single PR and merge this before? |
I think it’s better to first merge the API change, so that if someone stumbles upon the dev branch, they’re not going to see the dummybuffers as intended behaviour. |
0f75869
to
c346652
Compare
c346652
to
eee4ec2
Compare
68b9405
to
705eede
Compare
test/host/hls/test.cpp
Outdated
|
||
std::vector<unsigned int> dest = {0}; | ||
|
||
CCLO_BFM cclo(options.start_port, rank, size, dest, callreq, callack, data_cclo2krnl, data_krnl2cclo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not applicable on hardware. When I run it with the axis3x design for U55c it tries to connect to a non-existing ZMQ server and the test crashes with CCLO @0x0: during copy the following error(s) occured: DMA DECODE ERROR, DMA NOT OKAY ERROR (00000000000000000000010100)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I create a BFM, which is not used in hardware. So I have to change this. But the error sounds like something else is... not okay. Let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the BFM creation for hardware builds. But I get the same error during hardware execution. Maybe we need a recent build to test this. It works in the simulator though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which hardware are we targeting for running this test? the vadd_put and copy tests seem to require different PL kernels attached to the CCLO. Tests on hardware will either fail one or the other
I moved the copy stream test to the XRT test suite since it should work with the default loopback kernel. In the HLS suite it would lead to problems in hardware. It now works for me when I execute the XRT test across two U55C. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the wrong naming scheme for the hostctrl kernel this works on hardware and emulator.
2e10526
to
557fa5f
Compare
Allow to use the copy operation to copy data from stream to buffer and from buffer to stream.
Adds a test to the hls test suite to show this behavior.