Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware segmentation #127

Merged
merged 9 commits into from
Dec 2, 2022
Merged

Conversation

TristanLaan
Copy link
Contributor

No description provided.

Copy link
Collaborator

@quetric quetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert files that have only cosmetic changes.

Copy link
Collaborator

@quetric quetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firmware header is still whitespace-only changes. Please also remove debug print in allreduce function in firmware.

@quetric quetric merged commit c40db96 into Xilinx:dev Dec 2, 2022
@TristanLaan TristanLaan deleted the firmware_segmentation branch December 2, 2022 10:35
@TristanLaan TristanLaan restored the firmware_segmentation branch December 2, 2022 10:35
@TristanLaan TristanLaan deleted the firmware_segmentation branch December 2, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning for ACCL operations on too large data buffers
2 participants