Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2020.2 #26

Merged
merged 15 commits into from
Dec 7, 2021
Merged

Update to 2020.2 #26

merged 15 commits into from
Dec 7, 2021

Conversation

mariodruiz
Copy link
Contributor

@mariodruiz mariodruiz commented Sep 10, 2021

  • Fix the kernel to work with streams properly
  • Some housekeeping with repeated files

This fixes #22 #20 #25

@mariodruiz mariodruiz marked this pull request as draft September 13, 2021 15:00
@mariodruiz mariodruiz marked this pull request as ready for review September 27, 2021 18:56
@jancumps
Copy link

jancumps commented Nov 21, 2021

I tried this, and everything builds OK in Vitis HLS and Vivado, both 2020.2, Pynq 2.6

The accelerated function doesn't return though. It hangs on execution:

image

It works if I download and use the .bit file refered to in https://github.com/Xilinx/PYNQ-HelloWorld/blob/master/pynq_helloworld/notebooks/edge/resizer.bit.link for the Z2 (https://www.xilinx.com/bin/public/openDownload?filename=pynqhelloworld.resizer.pynqz2.bit).
Not with the bit file generated by the Vitis HLS and Vivado (both 2020.2) scripts.

I will try again as soon as I have a 2.7 SD made.

@mariodruiz
Copy link
Contributor Author

Are you using Pynq-Z2?

@jancumps
Copy link

jancumps commented Nov 22, 2021

Are you using Pynq-Z2?

Yes. I am using a Zynq-Z2 with Pynq2.6. I used the Zynq-Z2 folder to make the Vivado project.
I used your repository/branch for this pull request: mariodruiz:image_v2.7_2020.2

@mariodruiz
Copy link
Contributor Author

Did you use Vivado/Vitis HLS 2020.2?

@jancumps
Copy link

jancumps commented Nov 22, 2021

Did you use Vivado/Vitis HLS 2020.2?

Correct. I used version 2020.2 for both tools. And both Vitis HLS and Vivado gave a successful build.

edit: I used this command to get the source + vitis_lib dependecies:
git clone -b image_v2.7_2020.2 https://github.com/mariodruiz/PYNQ-HelloWorld.git --recursive

@mariodruiz
Copy link
Contributor Author

PYNQ SD 2.7 has just been released. Can you please burn an SD card with the new version and try again?

@jancumps
Copy link

I will test and report back.

@mariodruiz
Copy link
Contributor Author

Apologies, I had forgotten to push the latest changes. Please try with commit 02da054, it should work with PYNQ 2.6 and 2.7

@jancumps
Copy link

Testing ...

@jancumps
Copy link

Success !
image

Vitis HLS 2020.2
Vivado 2020.2
Pynq 2.6 (I will test with 2.7 later, need to get a new SD card)

@mariodruiz
Copy link
Contributor Author

Just tested on 2.7. But, if you can double check it would be great!

@jancumps
Copy link

jancumps commented Nov 22, 2021

Just tested on 2.7. But, if you can double check it would be great!

Checked. It works with 2.7 too. Thank you.

@npurusho npurusho merged commit bc98091 into Xilinx:image_v2.7 Dec 7, 2021
@mariodruiz mariodruiz deleted the image_v2.7_2020.2 branch December 10, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants