Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interrupt documentation #1246

Merged
merged 7 commits into from Oct 8, 2021

Conversation

mariodruiz
Copy link
Collaborator

  • Improve interrupt documentation by including this Peter's post https://discuss.pynq.io/t/zynq-ps7-interrupts/198/2
  • Return a warning when interrupts are used, but they are not associated to an interrupt controller, thus preventing the Overlay creation to fail.

This Fixes Xilinx/PYNQ-Dev#338

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1246 (61f7616) into image_v2.7 (2e317aa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           image_v2.7    #1246      +/-   ##
==============================================
- Coverage       46.74%   46.72%   -0.02%     
==============================================
  Files              27       27              
  Lines            4895     4897       +2     
  Branches          818      818              
==============================================
  Hits             2288     2288              
- Misses           2550     2552       +2     
  Partials           57       57              
Impacted Files Coverage Δ
pynq/pl_server/hwh_parser.py 17.64% <0.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e317aa...61f7616. Read the comment docs.

@PeterOgden
Copy link
Contributor

We support interrupts without a controller - just only attached to interrupt line 0. There's even a test for it.

@mariodruiz mariodruiz marked this pull request as draft September 2, 2021 14:28
@mariodruiz mariodruiz marked this pull request as ready for review September 6, 2021 14:16
@mariodruiz
Copy link
Collaborator Author

Ready for review

@PeterOgden PeterOgden merged commit 592c06b into Xilinx:image_v2.7 Oct 8, 2021
@jancumps
Copy link
Contributor

jancumps commented Nov 19, 2021

Maybe include this improvement: https://discuss.pynq.io/t/zynq-ps7-interrupts/198/10?
It solves the issue that the example failed every other execution.

I'll create a pull request.

@mariodruiz
Copy link
Collaborator Author

@jancumps,

Would you like to contribute these changes? f so, please open submit a PR

@jancumps
Copy link
Contributor

I just did, #1318

@mariodruiz mariodruiz deleted the image_v2.7.interrupt branch January 29, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants