aie/d/06-fft2d_AIEvsHLS: Fixed FFT tutorial issue #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrickysu
changed the title
imrickysu
reviewed
May 24, 2023
| @@ -39,7 +39,7 @@ | |||
| //////////////////////////////////////////////////////// | |||
| // FFT_2D Datatype related Macros | |||
| // datatypes can be, cint16 (Default) or cfloat... | |||
| #if FFT_2D_DT == cint16 | |||
| #if FFT_2D_DT == 0 | |||
There was a problem hiding this comment.
The comment above says "FFT_2D Datatype related Macros datatypes can be, cint16 (Default) or cfloat".
Since it's now changed to 0 and 1, could you update its definition in comments?
There was a problem hiding this comment.
Since the FFT_2D_DT was mentioned as 0 in the Make command ["make run TARGET=hw FFT_2D_DT=0 FFT_2D_INSTS=1 ITER_CNT=16 EN_TRACE=1 FFT_2D_PT=64"] , I added the condition - if FFT_2D_DT = 0, then FFT_2D_TT_DATA =cint16 and vice versa for cfloat in all the source files .
CRTejaswi
pushed a commit
to CRTejaswi/amd-vitis
that referenced
this pull request
Oct 3, 2023
d4e5e54 Merge pull request Xilinx#405 from RepoOps/update_makefile_20220908-222449 03f4bf7 Merge pull request Xilinx#406 from leol/json-parser-enhance 7e46545 Align producer/consumer(s) write/read operations to the same cycle 760f198 Merge remote-tracking branch 'upstream/next' into json-parser-enhance 8edfc57 update Makefile 3015528 remove HOST_ARCH from docs (Xilinx#404) 3362f73 Fix typo 7d76413 Merge pull request Xilinx#403 from leol/json-parser-enhance 2797903 Fix typo 69a7798 Doc for enhanced JSON parser 9bd6e67 Merge pull request Xilinx#402 from Zhenhong/next 85be3c2 update release notes 39c66fe Merge pull request Xilinx#401 from liyuanz/next b5383a7 Merge pull request Xilinx#400 from sibow/CR-1128650 2db9c59 update mk 7fac0c4 CR-1137153: fix undefined reference errors (Xilinx#399) abb1432 specify SWIG_LIB path 77bf014 Merge pull request Xilinx#395 from leol/json-parser-enhance b586c85 Merge pull request Xilinx#398 from liyuanz/add_time 2862751 Shrink test scale for resolving timeout issue 1429edd Merge remote-tracking branch 'upstream/next' into json-parser-enhance 7155054 Support array on leaf-node for JSON parser d6c1c3a add time 58a7883 add time 8562291 Merge pull request Xilinx#393 from sibow/string_apis a3c4d38 fix bug and add comments b13770a remove dup include file (Xilinx#397) f6b04f9 Merge remote-tracking branch 'upstream/next' into json-parser-enhance 61af200 Fix for CR-1137154 a0f382a revert Makefile (Xilinx#396) 55e8f0d update docs in next branch for portal (Xilinx#394) 64a71b6 Refactor code to utilize template parameters for jsonParser 6012fb5 Merge remote-tracking branch 'upstream/next' into json-parser-enhance 196ebec Enhance JSON parser to support nested field 08b5e1e modify description 3019c6b fix bug b54a081 add string like and testcase b317d0c rename project 045dbca add testcase for string in/not_in ef6abaa fix bug d4ec31c add random input string 534f0f8 refactor 7a4b3bb Merge pull request Xilinx#391 from leol/json-parser-enhance 4d50dfb add testcase for string equal 549498d init commit for string EQ/NE/IN 4094b3a Merge pull request Xilinx#390 from sibow/fix_CR1135034 1ccc65f Merge branch 'next' into fix_CR1135034 b095b3e Update Makefile 32c6bbc Trigger auto regression test 141953f Merge remote-tracking branch 'upstream/next' into json-parser-enhance ed3d71b update makefile (Xilinx#392) d0129c5 Refactor object definition to use the same base object 816b9ab Fix bug in readSchema of JSON parser ff31988 modify description.json to pass checker test 677d736 22.2 mks (Xilinx#388) 3c38777 Merge pull request Xilinx#386 from shengl/next f4126ee revert version 846eb9a update to 22.1 shell 40190b6 Merge pull request Xilinx#383 from leol/port-to-u50 26d5b7a Modify error message aef55ec Remove O_DIRECT flag for non-p2p scenario 0bd9747 Add checker for pread + eliminate redundant fopen efe55b5 Avoid overwrite for non-nvme device 23cfb5d Add macro guard for disabling P2P in other non-U2 devices d68ee86 Port CSV scanner to U50 f3f0f8d Merge pull request Xilinx#380 from changg/132.patch_next 7d2b8f6 132.patch 45581e6 fix readme (Xilinx#378) 826c982 Merge remote-tracking branch 'upstream/next' into next c431767 Merge pull request Xilinx#372 from leol/add-readme 940aa93 Doc for L3 CSV scanner 32be889 Fix issues in old doc b166509 change 2022.1_stable_latest to 2022.2_stable_latest 304cd6c fix u2 name confusing (Xilinx#369) 5d14a17 syntax error (Xilinx#370) 8698138 add known issue for log analyzer Co-authored-by: sdausr <sdausr@xilinx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the missing arguments in Makefile and sourcefiles.