Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRT OS Support for RHEl 8.8 and 9.2 #7603

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

ManojTakasi
Copy link
Collaborator

Problem solved by the commit

Providing XRT support for RHEl 8.8 and 9.2.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

NA

How problem was solved, alternative solutions (if any) and why they were rejected

By adding appropiate checks in the xocl_drv.h file and ulite.c file

Risks (if any) associated the changes in the commit

Low

What has been tested and how, request additional testing if necessary

Tested xrt package creation and installation on RHEL 8.8 and RHEL 9.2 VM

Documentation impact (if any)

NA

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jun 26, 2023

Can one of the admins verify this patch?

@chvamshi-xilinx
Copy link
Collaborator

add to whitelist

@chvamshi-xilinx
Copy link
Collaborator

ok to test

#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9, 1)
#define RHEL_9_1_GE
#endif
#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9, 0)
#define RHEL_9_0_GE
#endif
#if RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(8, 7)
#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(8, 7)
#define RHEL_8_7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to rename this to RHEL_8_7_GE

@dayeh-xilinx
Copy link

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 26, 2023

Build failed :(

@dayeh-xilinx
Copy link

retest this please.

@sabarinaxil
Copy link

retest this please

1 similar comment
@sabarinaxil
Copy link

retest this please

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 26, 2023

Build failed :(

@manikandan-xilinx
Copy link
Collaborator

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 27, 2023

Build failed :(

@manikandan-xilinx
Copy link
Collaborator

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jun 27, 2023

Build Passed!

@chvamshi-xilinx chvamshi-xilinx merged commit 6eff2fc into Xilinx:master Jun 27, 2023
3 checks passed
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
michaellass pushed a commit to pc2/XRT that referenced this pull request Oct 19, 2023
* XRT OS Support for RHEl 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

* Made few changes to provide OS support for RHEL 8.8 and 9.2

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>

---------

Signed-off-by: Manoj Takasi <mtakasi@xsjubn18vda.xilinx.com>
(cherry picked from commit 6eff2fc)
@ManojTakasi ManojTakasi deleted the 2023.1_test branch December 12, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants