Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple CRs: initialize tile type, compare tiles in maps, and properly replace paired sets #8408

Merged
merged 11 commits into from
Sep 12, 2024

Conversation

pgschuey
Copy link
Collaborator

Problem solved by the commit

  • Paired sets were not getting replaced correctly

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

  • Multiple bugs in code found from testing

How problem was solved, alternative solutions (if any) and why they were rejected

  • Properly initialize tile_type struct
  • Add compare capabilities for tiles in maps
  • Replace paired sets for current module type

Risks (if any) associated the changes in the commit

  • Initializing tile_type may lead to unforeseen issues, but it's the proper thing to do.

What has been tested and how, request additional testing if necessary

  • Tested various designs on vck190 and vek280

Documentation impact (if any)

  • None

Paul Schumacher and others added 9 commits September 3, 2024 14:51
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Paul Schumacher added 2 commits September 10, 2024 20:07
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@jvillarre jvillarre merged commit e4e43f9 into Xilinx:master Sep 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants