[XDP] Fix for profiling plugins to work on independent compilation designs #8424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
vipangul
requested review from
pgschuey and
jvillarre
and removed request for
jvillarre
pgschuey
requested changes
Sep 17, 2024
src/runtime_src/xdp/profile/database/static_info/filetypes/aie_trace_config_filetype.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
vipangul
force-pushed
the
indCompileShift
branch
from
c17cdf4
to
c62c37b
Compare
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
jvillarre
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
[CR-1201066][CR-1211412] Independent compilation designs were failing for AIE Trace/Profile plugin
Update: AIE Status Plugin is also supported on Edge.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
Metadata has partition column start shift available. This is now accounted to get the absolute column location from relative locations in metadata.
Risks (if any) associated the changes in the commit
Minimal . by default shift is zero if partition shift is not populated or older metadata is used
What has been tested and how, request additional testing if necessary
Verified on VCK190 Edge.
Update: AIE Status Plugin is also verified on Edge.
Documentation impact (if any)