Starting trace module using a broadcast network for XDP Client #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyothees99
requested review from
jvillarre,
stsoe and
rozumx
as code owners
|
Can one of the admins verify this patch? |
Signed-off-by: jyothees <Jyotheeswar.Ganne@amd.com>
…pl to avoid calling get_aie_trace_settings_trace_start_broadcast ini settings multiple times Signed-off-by: jyothees <Jyotheeswar.Ganne@amd.com>
…itions Signed-off-by: jyothees <Jyotheeswar.Ganne@amd.com>
…f XDP client trace Signed-off-by: jyothees <Jyotheeswar.Ganne@amd.com>
jyothees99
force-pushed
the
trace_start_through_broadcast
branch
from
faf5b57
to
d38c5a3
Compare
jvillarre
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Trace modules are being started at different times. Because of this, trace start can't be used to verify timer synchronization.
How problem was solved, alternative solutions (if any) and why they were rejected
A broadcast network is used to start the trace modules. Alternative solution is to start trace module using true event sequentially. But the differences between timers of trace modules will be hundreds of cylces. With broadcast network, the difference is too less.
What has been tested and how, request additional testing if necessary
On client I have verified one model. The timers were in sync and trace module starts with broadcast event.