-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve KServe compatibility #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Build successful! |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Build successful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #5
Motivation
Compatibility with the KServe is a key feature of the inference server.
Implementation
Changing STRING to BYTES is a nomenclature change. It could still use some implementation changes because internally it's dealt with as
char
as opposed tostd::byte
.Versioning support is a more substantial feature. Versioning is only supported for
modelLoad
where it's loading from a repository. The other caveat is that if you load a versioned model, then you can only interact with the model with versioned APIs. The standard non-versioned APIs continue to exist. For versioned models, a version string is suffixed to the endpoint to allow for multiple versions of the model to be active at a time. Non-versioned models omit the version suffix entirely. The implementation uses an empty version string to indicate no version.The KServe spec is inconsistent with its definition for the type of shape. In text, it says
uint64
but the gRPC proto definition usesint64
. Using int64 for shape allows the server to specify dynamic shape sizes (e.g. using -1920 indicates the shape could be up to 1920) for models that don't have fixed sizes.Notes
N/A