[aievec] Canonicalize transposed B contract op. #1475
Conversation
jsetoain
force-pushed
the
extract-innermost-dim-perm-from-contract
branch
4 times, most recently
from
2be4a48
to
c2c73de
Compare
| SmallVector<vector::IteratorType> iterators = op.getIteratorTypesArray(); | ||
| auto innerMostIterators = | ||
| SmallVector<vector::IteratorType>(iterators.end() - 3, iterators.end()); |
There was a problem hiding this comment.
It's possible that len(iterator_types)<3?
There was a problem hiding this comment.
It's possible that
len(iterator_types)<3?
I don't think so, no. At that point I've already checked that lhs/rhs/acc have at least 2 dimensions each, which implies at least 2 parallel dimensions (acc) and there has to be at least one contracting dimension.
Edit: I've done the experiment, for the sake of it, and it looks like it does accept having 2d operands and accumulator, and only two iterators (one a reduction). I'm pretty sure that's a mistake, though. I need to check.
jsetoain
force-pushed
the
extract-innermost-dim-perm-from-contract
branch
from
c2c73de
to
55e7a06
Compare
| @@ -411,6 +460,107 @@ struct FlattenMultDimTransferWritePattern | |||
| } | |||
| }; | |||
|
|
|||
| // This pattern takes out an implicit transposition of the `rhs` operand in a | |||
There was a problem hiding this comment.
I suggest to clarify the comment as follows:
an implicit transposition of the rhs operand
=>
an implicit transposition of the 2 innermost dimensions of the rhs operand
No description provided.