-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing improvements #1492
Tracing improvements #1492
Conversation
Can you make it work on https://github.com/Xilinx/aie-rt/blob/main-aie/driver/src/events/xaie_events_aieml.h? I think those are the aie2 events. |
Good catch, fixed it. I got lucky that the event numbers were mostly the same between AIE1 and 2 but was clearly using the wrong header file |
Looks like there are some tests that need updating. I will look into this next week. |
I have decided to make it mandatory to specify the port you want to generate events for if an event like PORT_RUNNING_0 is specified. This required updating a test. Please let me know if anyone thinks this is a bad idea. |
@fifield Would you mind having another look at this too, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Have you thought about how we could add testing for the trace infrastructure or use trace to have "performance" tests that check execution against an expected cycle count
I have not yet, but that would be interesting. I'll merge this as it is for now |
This updates the tracing utilities in
python/utils/trace.py
as well as the tracing parse scripts inprogamming_examples/utils
.python/utils/trace_events_enum.py
contains an enumeration of all available tracing events. This is automatically generated from this header file in aie-rt using the newutils/generate_events_enum.py
script.Please let me know what you think.