Make aiex.npu.dma_memcpy_nd d0 stride explicit #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
requested review from
makslevental,
AndraBisca,
erieaton-amd,
newling,
denolf and
jgmelber
as code owners
fifield
force-pushed
the
npu_memcpy_d0_stride
branch
from
361705c
to
5fcb734
Compare
Coverage ReportCreated: 2024-06-28 20:13Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
andrej
approved these changes
Jul 1, 2024
| // strides[0] == 1 is ok iff the tranfer size is a multiple of | ||
| // addressGranularity, which is checked below | ||
| if (i == 0 && raw_strides[i] == 1) | ||
| continue; |
There was a problem hiding this comment.
Looks good. Technically something like
sizes=[addressGranularity/2, addressGranularity/2]
strides=[addressGranularity/2, 1]
(and similar examples for higher dimensions, with addressGranularity in bytes)
is equivalent to
sizes=[addressGranularity]
strides=[1]
but would currently error.
I think it's a non-issue as this is clearly a contrived example with no real uses. (Except maybe automatically generated code?)
So this looks good to me with this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stride of the inner dimension is assumed to be one for npu.dma_memcpy_nd (e.g. here). This PR makes it an explicit operand.
replaces #1584