Devnet Update Query #214
Merged
Devnet Update Query #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-lai
reviewed
Dec 7, 2022
eth/api_backend.go
Outdated
| @@ -81,6 +82,22 @@ func (b *EthApiBackend) HeaderByNumber(ctx context.Context, blockNr rpc.BlockNum | |||
| // Otherwise resolve and return the block | |||
| if blockNr == rpc.LatestBlockNumber { | |||
| return b.eth.blockchain.CurrentBlock().Header(), nil | |||
| } else if blockNr == rpc.ConfirmedBlockNumber { | |||
| if b.eth.chainConfig.XDPoS == nil { | |||
| return nil, errors.New("PoW does not support confirmed block loopup") | |||
| return b.eth.blockchain.GetHeaderByHash(confirmedHash), nil | ||
| } else { | ||
| return nil, errors.New("PoS V1 does not support confirmed block loopup") | ||
| } |
wgr523
approved these changes
Feb 2, 2023
wjrjerome
requested changes
Feb 2, 2023
span14
force-pushed
the
devnet-update-query
branch
from
d9e6a9a
to
5aff0d3
Compare
wjrjerome
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a new
rpc.BlockNumbertype calledConfirmedBlockNumber, which serves to provide users access to the finalized block in V2.