subnet deployment generator v0.2.1 #114
Conversation
commit 782ba794f04f6018d1c33015aea72803a44e4ebc
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Thu Jan 4 15:08:39 2024 +0400
bump relayer
commit 676f307
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Thu Jan 4 14:49:53 2024 +0400
rm files
commit dfeb315
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Jan 3 16:28:19 2024 +0400
trig
commit 8aa3991
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Jan 3 16:25:35 2024 +0400
remove old csc style cicd
commit 1e6e14e
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Jan 3 15:03:31 2024 +0400
fix wrong entrypoint
commit 0ce0ddf
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Jan 3 15:03:10 2024 +0400
rm old csc deploy style
commit 5392466
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Jan 3 14:27:20 2024 +0400
rm debug to force exit code 1 when fails
commit a5f2921
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Thu Dec 21 21:35:22 2023 +0400
fix mount path
commit 2041ef3
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Thu Dec 21 21:16:45 2023 +0400
update for csc
commit 26d190b
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Wed Dec 20 16:06:31 2023 +0400
update generate sh
commit 8869924
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Tue Dec 19 15:54:30 2023 +0400
upd dockerfile
commit f3330bf
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Tue Dec 19 15:49:30 2023 +0400
update new way generation
commit 34f152b
Author: wanwiset25 <wanwiset25@gmail.com>
Date: Tue Dec 19 15:07:55 2023 +0400
update config
| echo 'checking docker images' | ||
| if [[ -z "$(docker images -q xinfinorg/subnet-generator:$VERSION_GENERATOR)" ]]; then # || echo "doesn't exist" | ||
| docker pull xinfinorg/subnet-generator:$VERSION_GENERATOR | ||
| fi | ||
| if [[ -z "$(docker images -q xinfinorg/csc:$VERSION_CSC)" ]]; then # || echo "doesn't exist" | ||
| docker pull xinfinorg/csc:$VERSION_CSC | ||
| fi | ||
| if [[ -z "$(docker images -q xinfinorg/xdcsubnets:$VERSION_SUBNET)" ]]; then # || echo "doesn't exist" | ||
| docker pull xinfinorg/xdcsubnets:$VERSION_SUBNET | ||
| fi |
There was a problem hiding this comment.
why you need to do these steps? If docker images not there, docker compose up will download it by default right?
There was a problem hiding this comment.
This is for speeding up when the images are already present. I found docker pull command takes a long time.
It's not too big of an optimization. Does it look too error prone this way?
There was a problem hiding this comment.
no, all good then. If this is helping speeding up, then it's good to have.
| subnet: (process.env.VERSION_SUBNET || 'v0.2.1'), | ||
| bootnode: (process.env.VERSION_BOOTNODE || 'v0.2.1'), | ||
| observer: (process.env.VERSION_OBSERVER || 'latest'), | ||
| relayer: (process.env.VERSION_RELAYER || 'v0.2.1'), | ||
| // observer: (process.env.VERSION_OBSERVER || 'latest'), | ||
| relayer: (process.env.VERSION_RELAYER || 'v0.2.2'), | ||
| stats: (process.env.VERSION_STATS || 'v0.1.8'), | ||
| frontend: (process.env.VERSION_FRONTEND || 'v0.1.8'), | ||
| // csc: (process.env.VERSION_CSC || 'v0.1.1'), | ||
| csc: (process.env.VERSION_CSC || 'v0.1.1'), | ||
| // zero: (process.env.VERSION_ZERO || 'v0.1.1') |
There was a problem hiding this comment.
put latest tag is better, you won't need to change it again and again.
There was a problem hiding this comment.
I think latest will cause many different version groupings and they are not guaranteed to be compatible. In the current way we can control official release versions and only refer to the latest generator. Also latest causes issues with checking current version or accidental updates with docker pull.
There was a problem hiding this comment.
hmm dependency versioning... I got you now.
|
Can we move versions into configuration file? |
thanks, let me do it in next PR |
-new generation style
-new csc image
-supports upgradable csc