Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RotateRad operation #24

Closed
Xkonti opened this issue Sep 15, 2023 · 6 comments · Fixed by #49
Closed

Implement RotateRad operation #24

Xkonti opened this issue Sep 15, 2023 · 6 comments · Fixed by #49
Assignees
@sathuhebbar
Labels
enhancement New feature or request hacktoberfest Issues that qualify towards Hacktoberfest goals.
Milestone
v1.0.0

Comments

@Xkonti
Copy link
Owner

Xkonti commented Sep 15, 2023 •
edited
Loading

Rotates a vector by an angle specified in radians.

Functions for integer vectors should return a float vector.
@Xkonti Xkonti added the enhancement New feature or request label Sep 15, 2023
@Xkonti Xkonti added this to the v1.0.0 milestone Sep 15, 2023
@Xkonti Xkonti added the hacktoberfest Issues that qualify towards Hacktoberfest goals. label Oct 2, 2023
@sathuhebbar
Copy link
Contributor

Right, can I work on this?

@Xkonti
Copy link
Owner Author

Xkonti commented Oct 6, 2023

Sure, But I'm not sure what's the usual approach for 3D vectors here. RotateRadXAxis? RotateRadPlane? RotateRadQuaternion? Do you have any suggestions?

@Xkonti
Copy link
Owner Author

Xkonti commented Oct 9, 2023

@sathuhebbar I think for now let's limit it only to V2F and V2I vectors. This way rotation will be easy to implement. I have plans for 3D vectors for after v1.0.0

@sathuhebbar
Copy link
Contributor

Oh cool. I was just looking up 3D rotations and thought we could use quaternion rotation. But for now, I'll implement these.

@Xkonti
Copy link
Owner Author

Xkonti commented Oct 9, 2023

Yeah. After 1.0.0 I'm thinking about adding concepts of "quaternions" and "planes" to allow more advanced 3D vector operations but without having to have a PHD in math.

@sathuhebbar sathuhebbar mentioned this issue Oct 9, 2023
Merged
@sathuhebbar
Copy link
Contributor

pHD in math XD. Yup having a quaternion type would make it convenient. I've added the 2D vector methods here.

Thanks!

Xkonti pushed a commit that referenced this issue Oct 10, 2023
@sathuhebbar
Add 2D Vector rotation by radians operation (#49)
b9e95d3 
Added a file `rotateRad.go`:

1. Provides rotation by radians for 2D vectors only
2. Closes #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sathuhebbar sathuhebbar

Labels
enhancement New feature or request hacktoberfest Issues that qualify towards Hacktoberfest goals.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add 2D Vector rotation by radians operation sathuhebbar/govec
2 participants
@Xkonti @sathuhebbar