Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.10 compatibility : remove old buffer api #3031

Closed
totaam opened this issue Feb 23, 2021 · 1 comment
Closed

python 3.10 compatibility : remove old buffer api #3031

totaam opened this issue Feb 23, 2021 · 1 comment

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 23, 2021

See python/cpython#21117

Almost all the callers go via https://github.com/Xpra-org/xpra/blob/master/xpra/buffers/buffers.c

The only caller for object_as_write_buffer is unpremultiply_argb_in_place which is only used for cursors and window icons, so we could just copy the data if that makes it easier to move away from the old buffer api.

The read-only object_as_buffer variant has many callers:

$ grep -r object_as_buffer . | egrep -v "import|cdef|_object_as_buffer" | wc -l
41
@totaam
Copy link
Collaborator Author

totaam commented May 31, 2021

This was worth doing, found a major bug in the webp encoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant