Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pam] BufferError: PyBuffer_FillInfo: view==NULL argument is obsolete #3148

Closed
goekce opened this issue May 31, 2021 · 1 comment
Closed

Comments

@goekce
Copy link
Contributor

goekce commented May 31, 2021

I was using 829b9ea and installed the newest commit. Authentication fails for both LDAP and local users on my xpra proxy. I use pam for both TCP_AUTH and AUTH:

...
make_authenticators('tcp', 'USERNAME', ws socket: ::ffff:127.0.0.1, 14500, 0, 0 <- ::ffff:127.0.0.1, 42102, 0, 0) socket options={}
creating authenticators ('pam', <module 'xpra.server.auth.pam_auth' from '/usr/lib/python3.9/site-packages/xpra/server/auth/pam_auth.py'>, <class 'xpra.server.auth.pam_auth.Authenticator'>, {'exec_cwd': >
authenticator 0: pam(USERNAME, {'exec_cwd': '/', 'connection': ws socket: ::ffff:127.0.0.1, 14500, 0, 0 <- ::ffff:127.0.0.1, 42102, 0, 0})=PAM
processing authentication with (PAM,), remaining=(PAM,), digest_modes=(...
authenticator[0]=PAM, requires-challenge=True, challenge-sent=False
get_challenge(...
Authentication required by PAM authenticator module 1
 sending challenge for username 'USERNAME' using xor digest
processing authentication with (PAM,), remaining=(PAM,), digest_modes=(...
authenticator[0]=PAM, requires-challenge=True, challenge-sent=True
combined salt...
authenticate_check(...
pam.check(..) pw=pwd.struct_passwd(pw_name='USERNAME', pw_passwd='x', pw_uid=12345, pw_gid=10001, pw_gecos='USER NAME', pw_dir='/home/USERNAME', pw_shell='/bin/bash')
pam check(USERNAME, [..])
check(..)
BufferError: PyBuffer_FillInfo: view==NULL argument is obsolete
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/xpra/server/auth/sys_auth_base.py", line 162, in authenticate_check
    ret = self.check(password)
  File "/usr/lib/python3.9/site-packages/xpra/server/auth/pam_auth.py", line 48, in check
    return check(self.username, password, self.service, self.check_account)
  File "/usr/lib/python3.9/site-packages/xpra/server/auth/pam_auth.py", line 23, in check
    if not session.start(b(password)):
  File "xpra/server/pam.pyx", line 168, in xpra.server.pam.pam_session.start
SystemError: <class 'Exception'> returned a result with an error set
Error: PAM authentication check failed: 
 <class 'Exception'> returned a result with an error set
Warning: authentication failed
 authentication failed
...

The referenced line:

raise Exception("failed to read password data")

Does someone have any ideas for further debugging?

totaam added a commit that referenced this issue May 31, 2021
@totaam
Copy link
Collaborator

totaam commented May 31, 2021

Oops, sorry!
This was caused by #3031, fixed in ae56b87 + 7f9ca3d. (not yet tested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants