Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(de): Optional struct containing only an Option should still deserialize #25

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix(de): Optional struct containing only an Option should still deserialize #25

merged 1 commit into from
Jan 17, 2023

Conversation

Tony-Samuels
Copy link
Contributor

@Tony-Samuels Tony-Samuels commented Jan 17, 2023 •
edited
Loading

Fixes #24

Xuanwo
Xuanwo approved these changes Jan 17, 2023
View reviewed changes
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Xuanwo Xuanwo merged commit 52164f6 into Xuanwo:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional structs with an Option value always deserialize to None
2 participants
@Tony-Samuels @Xuanwo