Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content within code blocks under list items treated as errors #43

Closed
fviolette opened this issue Dec 19, 2022 · 3 comments
Closed

Content within code blocks under list items treated as errors #43

fviolette opened this issue Dec 19, 2022 · 3 comments
Labels
bug Something isn't working released

Comments

@fviolette
Copy link

Hello,

Thanks for these utils!
Code blocks within list items are reporting what I think are false positives.

The problem

Indented code blocks under list items are processed as errors:

1. Run this script in your browser to prevent 'AAA' masking from effecting your local session:
    
    ```javascript
    window._uxa = window._uxa || [];
    window._uxa.push(["trackConsentGranted"]);
    ```
    
1. Do something else.

    ```javascript
    console.log('ok');
    ```

Inconsistent list item capitalization: "w" should be "W" eslint(remark-lint-list-item-style)
Inconsistent list item capitalization: "c" should be "C" eslint(remark-lint-list-item-style)

My .remarkrc.js file:

module.exports = {
  settings: {
    "bullet": "-",
    "incrementListMarker": false,
  },
  plugins: [
    "remark-frontmatter",
    // https://github.com/remarkjs/remark-lint/tree/main/packages/remark-preset-lint-markdown-style-guide#rules
    "remark-preset-lint-markdown-style-guide",
    ["remark-lint-first-heading-level", 2],
    ["remark-lint-no-duplicate-headings", false],
    ["remark-heading-gap", 1],
    ["remark-lint-maximum-heading-length", false],
    ["remark-lint-list-item-indent", 'space'],
    ["remark-lint-list-item-content-indent", false],
    ["remark-lint-list-item-spacing", false],
    ["remark-lint-list-item-style", {
      "checkFirstWord": "capitalize",
      "checkPunctuation": false,
    }],
    ["remark-lint-fenced-code-flag", false],
    ["remark-lint-maximum-line-length", false],
    ["remark-lint-emphasis-marker", false],
    ["remark-lint-no-emphasis-as-heading", false],
  ],
};
@fviolette fviolette added the bug Something isn't working label Dec 19, 2022
@Xunnamius
Copy link
Owner

Nice catch! I'll check this out later today.

@Xunnamius
Copy link
Owner

@fviolette Should be patched in the latest version. Let me know if the problem persists.

Xunnamius added a commit that referenced this issue Dec 21, 2022
@Xunnamius
Copy link
Owner

🎉 This issue has been resolved in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants