-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WhenAll with output order same as input order #221
Conversation
using R = std::conditional_t<P == WhenPolicy::None, Result<V, E>, V>; | ||
auto [future_core, combinator] = detail::AllCombinator<R, E>::Make(count); | ||
detail::WhenImpl(combinator, begin, count); | ||
using R = std::conditional_t<F == FailPolicy::None, Result<V, E>, V>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general no difference between Fifo and Same if R is void.
So I think it always should be Fifo policy, and Same AllCombinator shouldn't work with void
void AddInput(BaseCore* core) noexcept { | ||
core->SetInline(*this); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not null => &
ResultCore<V, E>? to avoid cast
always inline?
044a438
to
db7f8b1
Compare
Pull Request Test Coverage Report for Build 3357611113
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 62 63 +1
Lines 1369 1414 +45
===========================================
+ Hits 1369 1413 +44
- Misses 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7329db7
to
0ada9ba
Compare
Purpose
ArangoDB needs it, I can use coroutine but need smaller diff
Related Information
Testing