Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-1076] Fix heading position for pages without alerts banner for mobile screens #82

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

aleevas
Copy link

@aleevas aleevas commented Nov 17, 2023

DS-1076

Steps to test:

  • Log in as admin https://sandbox-carnation-std-virtual-y.y.org/
  • Create a Landing page Layout Builder
  • Add Virtual Y Content block in LB and save the page
  • switch to mobile screen
  • As an anonymous user log in to the site, then open the created page scrolls down

Quality checks:

Please check these boxes to confirm this PR covers the following cases:

  • Maintaining our upgrade path is essential. Check one or the other:
    • This PR provides updates via hook_update_N or other means.
    • No updates are necessary for this change.
  • Front end fixes should be tested against all of the Open Y Themes.
    • Tested against Carnation
    • Tested against Lily
    • Tested against Rose
    • This change does not contain front-end fixes.
  • I have flagged this PR "Needs Review" or pinged the VY devs/QA
    team in Slack

@aleevas aleevas marked this pull request as ready for review November 20, 2023 10:41
@podarok podarok merged commit 70d5d1e into YCloudYUSA:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants