Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0xCAB0/Rust-module-optimization #13

Merged
merged 14 commits into from
Jan 16, 2024
Merged

0xCAB0/Rust-module-optimization #13

merged 14 commits into from
Jan 16, 2024

Conversation

0xCAB0
Copy link
Contributor

@0xCAB0 0xCAB0 commented Jan 12, 2024

Rust module refactor

I didn't touch the code functionality, I just re-organized the module for a better understanding of the project, I am more than welcome to work alongside to improve code quality, reliance and expand new features.

- Added documentation on modules
- Example methods
- Re-organized lib module and folder structure into a more coherent flow
- Added tests for each method
- Rust auto testing and clippy workflow added

New folder struct

└── src
    ├── clean.rs
    ├── lib.rs
    ├── models
    │   ├── method.rs
    │   └── page_type.rs
    └── tests.rs

We should come together to discuss better testing solutions, I'm a gulagcleaner user myself and that is why I decided to pick up this improvement.
Thank you for your work!

@YM162 YM162 self-requested a review January 16, 2024 13:12
@YM162 YM162 self-assigned this Jan 16, 2024
Copy link
Owner

@YM162 YM162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! The code and documentation looks amazing. And the tests were also extremely needed. TY for helping!

@YM162 YM162 merged commit b122c91 into YM162:main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants