Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change QR code provider #204

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Change QR code provider #204

merged 2 commits into from
Apr 15, 2024

Conversation

yakatz
Copy link
Contributor

@yakatz yakatz commented Apr 14, 2024

Legacy Google Charts QR Code API no longer exists

@yakatz yakatz requested a review from a team as a code owner April 14, 2024 16:38
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, not even the newer base URI from Google's current documentation works.

Please consider working in a link to this API's documentation and terms: https://goqr.me/api/doc/create-qr-code/

@yakatz
Copy link
Contributor Author

yakatz commented Apr 14, 2024

Indeed, not even the newer base URI from Google's current documentation works.

That is just a different hostname to the same legacy API - the actual new Google Charts API does not seem to have a QR code option. They announced this service would be deprecated years ago, but it seems to have just stopped serving requests in the last few days.

@yakatz yakatz requested a review from dgw April 14, 2024 18:21
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yakatz
Copy link
Contributor Author

yakatz commented Apr 14, 2024

Thank you. Looks like it is waiting for new approval for the CI jobs.

@LeoColomb LeoColomb merged commit 76ed372 into YOURLS:main Apr 15, 2024
3 checks passed
@yakatz yakatz deleted the qr-code-api branch April 15, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants