Preserve access_time and modification_time on newly created directori…

…es to allow the playbook to be idempotent.
YPCrumble · Apr 14, 2023 · 8bb9575 · 8bb9575
1 parent 2d3d0e3
commit 8bb9575
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/roles/celery/tasks/setup_supervisor.yml b/roles/celery/tasks/setup_supervisor.yml
@@ -16,11 +16,16 @@
             mode=0644
 
 - name: Create the log directory for {{ celery_application_name }}
-  ansible.builtin.file: path={{ celery_log_dir }}
-        owner={{ celery_user }}
-        group={{ celery_group }}
-        state=directory
-        mode=0644
+  ansible.builtin.file:
+    path: "{{ celery_log_dir }}"
+    owner: "{{ celery_user }}"
+    group: "{{ celery_group }}"
+    state: directory
+    mode: "0644"
+    # Set to `preserve` to make sure the task is idempotent.
+    # See https://github.com/ansible/ansible/issues/30226#issuecomment-433643224
+    access_time: preserve
+    modification_time: preserve
 
 - name: Check for an existing celery logfile
   ansible.builtin.stat:

diff --git a/roles/web/tasks/setup_virtualenv.yml b/roles/web/tasks/setup_virtualenv.yml
@@ -44,11 +44,17 @@
   tags: deploy
 
 - name: Create the application log folder
-  ansible.builtin.file: path={{ application_log_dir }}
-        owner={{ gunicorn_user }}
-        group={{ gunicorn_group }}
-        mode=0774
-        state=directory
+  ansible.builtin.file:
+    path: "{{ application_log_dir }}"
+    owner: "{{ gunicorn_user }}"
+    group: "{{ gunicorn_group }}"
+    mode: "0774"
+    state: directory
+    # Set to `preserve` to make sure the task is idempotent.
+    # See https://github.com/ansible/ansible/issues/30226#issuecomment-433643224
+    access_time: preserve
+    modification_time: preserve
+
 
 - name: Check for an existing application logfile
   ansible.builtin.stat: