Forge 1.16.3 - YBC breaking some vanilla/modded feature gen

[bessiq]

Forge: 34.1.0-34.1.1
BetterCaves-1.16.2-1.0.2.jar

Hi there,

I've encountered an issue when using Better Caves where some other features will not generate when BC is enabled. When entering the world selection screen or quitting a world, I will get entries in the log like this:

[01Oct2020 13:39:39.070] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "minecraft:end_island_decorated"
[01Oct2020 13:39:39.124] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "byg:rs_dead_sea_spike"
[01Oct2020 13:39:39.348] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "byg:embur_lake"
[01Oct2020 13:39:39.357] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "byg:crag_lake"
[01Oct2020 13:39:39.387] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "minecraft:end_island_decorated"
[01Oct2020 13:39:39.431] [Render thread/ERROR] [net.minecraft.world.biome.BiomeGenerationSettings/]: Feature: Not a JSON object: "byg:rs_dead_sea_spike"

The "byg" mod above is Oh The Biomes You'll Go, and I did go to the Dead Sea biome and confirmed the spike feature did not generate. I also tested in a separate instance with just Better Caves (using the default config), and I still get the error for the vanilla end island feature. Once BC is disabled, these errors disappear and the features generate properly. I've linked my logs below, if they are helpful:

debug/latest: https://gist.github.com/bessiq/3cb49801271594bdf455f82fc0776385

Thanks!

[CorgiTaco]

Could you use the mod "Blame" and upload a log with it? https://www.curseforge.com/minecraft/mc-mods/blame

[bessiq]

Unfortunately, Blame did not produce any additional info for this particular issue, but the dev will look into enhancing it so it may in the future. (Reference: TelepathicGrunt/Blame#1)

[yungnickyoung]

I think it's somehow messing up any other features added in the RAW_GENERATION step. I force my feature to be added in the first position of the RAW_GENERATION phase to imitate a carver, but looks like that causes problems with this version.

[TelepathicGrunt]

@yungnickyoung did you register your configured carver wrapper feature?

[yungnickyoung]

yeah

[TelepathicGrunt]

I just checked and I don't see CONFIGURED_BETTERCAVES_FEATURE being registered into the configured feature registry. If it is missing, try doing this after you register it into your feature registry:

MutableRegistry<ConfiguredFeature<?, ?>> registry = (MutableRegistry<ConfiguredFeature<?, ?>>) WorldGenRegistries.CONFIGURED_FEATURE;
        Registry.register(registry, new ResourceLocation(mod.MODID, "configured_better_caves_feature"), CONFIGURED_BETTERCAVES_FEATURE );