Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArmorPlus has several unregistered configuredfeatures #241

Closed
TelepathicGrunt opened this issue Dec 9, 2020 · 0 comments
Closed

ArmorPlus has several unregistered configuredfeatures #241

TelepathicGrunt opened this issue Dec 9, 2020 · 0 comments

Comments

@TelepathicGrunt
Copy link

TelepathicGrunt commented Dec 9, 2020

Hello! I was test running my mod called Blame with a bunch of mods and it seemed to have found that ArmorPlus has several ConfiguredFeatures that are not registered. This can be an issue for mod compatibility as under certain conditions, unregistered ConfiguredFeatures can basically prevent other mod's registered ConfiguredFeatures from spawning if in the same generation stage.

By that I mean, if mod A adds an unregistered CF to the ore generation stage and the biome's codec reaches it first, it will choke and basically nuke mob B's registered CFs afterwards. Here's a case where BetterCaves forgot to register their CF and caused several CFs from Oh The Biomes You'll Go to stop spawning in the world: YUNG-GANG/YUNGs-Better-Caves#75

Here's a more detailed explanation of why this happens in the biome's codec:
image

Specifically, when you call .withConfiguration on a Feature, you create a ConfiguredFeature. This is what should be registered to the WorldgenRegisties at mod init (you can do it in FMLCommonSetupEvent so you have your config ready too if it is needed).

Anyway here's an example from my mod RepurposedStructures of me registering all my ConfiguredFeatures.
https://github.com/TelepathicGrunt/RepurposedStructures/blob/584433a0745338802c84e9f498dc063c1f5505f8/src/main/java/com/telepathicgrunt/repurposedstructures/modinit/RSConfiguredStructures.java#L72-L74

I hope this helps!

From the log with Blame:
armorplus:ap_ore_feature
armorplus:ore_frost_crystal
armorplus:ore_frost_crystal_obsidian
armorplus:ore_frost_crystal_stone
armorplus:ore_lava_crystal
armorplus:ore_lava_crystal_obsidian
armorplus:ore_lava_crystal_stone

sokratis12GR added a commit that referenced this issue Jan 9, 2021
ConfiguredFeatures are now finally registered correctly. Fixes #241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants