This repository has been archived by the owner on Jul 18, 2020. It is now read-only.
forked from Wyk3d/YafaRay
-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
IMPORTANT: simplified interpolation/colorSpace. Now all imagebuffers …
…are internally linear and optimized by default. To avoid the "double RAM" requirement with the new "correct" texture interpolation, I've simplified the interpolation interface to remove the option "colorspace_interpolation_method" introduced in the previous commit. From now on, all image textures are stored in RAM as LinearRGB and no longer stored "as is". The "old-legacy" interpolation method used in old YafaRay versions will no longer be available. From now on the user will be responsible for selecting correct ColorSpaces for all textures, including bump map, normal map, etc. For example for Non-RGB / Stencil / Bump / Normal maps, etc, textures are typically already linear and the user should select "linearRGB" in the texture properties, but if the user (by mistake) keeps the default sRGB for them, YafaRay will (incorrectly) apply the sRGB->LinearRGB conversion causing the values to be incorrect. However, I've added a "fail safe" so for any "float" textures, bump maps, normal maps, etc, when getting colors after interpolatio YafaRay will to a "inverse" color conversion to the original Color Space. This way, even a mistake in user's color space selection in bump maps, normal maps, etc, will not cause any significant problems in the image as they will be converted back to their original color space. However, in this case rendering will be slower and potential artifacts can appear due to interpolation taking place in the wrong color space. For optimal results, the user must select correctly the color space for all textures. Also, all textures will be "optimized" by default. I think it's clear by now that optimized textures greatly improve memory usage and apparently don't cause slowdowns (might even make it slightly faster due to reduced RAM access?) Changes to be committed: modified: include/core_api/imagehandler.h modified: include/core_api/texture.h modified: include/textures/basictex.h modified: include/textures/imagetex.h modified: src/backgrounds/textureback.cc modified: src/bindings/yafaray_v3_interface.i modified: src/image_handlers/exrHandler.cc modified: src/image_handlers/hdrHandler.cc modified: src/image_handlers/jpgHandler.cc modified: src/image_handlers/pngHandler.cc modified: src/image_handlers/tgaHandler.cc modified: src/image_handlers/tifHandler.cc modified: src/textures/basicnodes.cc modified: src/textures/basictex.cc modified: src/textures/imagetex.cc modified: src/yafraycore/imagefilm.cc modified: src/yafraycore/imagehandler.cc
- Loading branch information
1 parent
22f0ac8
commit 003d614
Showing
17 changed files
with
217 additions
and
279 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.